Export SDL_SendKeyboardKey function to allow scancode injection in Emscripten build #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaicoianu
changed the title
Contributor
|
@jbaicoianu This sounds interesting. Could you showcase an example of such usage? |
Contributor
Author
|
@felipesanches sure - on archive.org we use a virtual keyboard to provide an easy interface for people to access necessary functions which don't map to obvious keyboard keys, like "add coin", "player 1 start", "reset", etc. For example, https://archive.org/details/arcade_outrun - after pressing the "power" button to boot the emulator, the virtual keyboard should load. The version currently used on the website does this using synthetic DOM events and an older version of MAME, but newer versions built with SDL2 don't work with these synthetic events. This change lets us bypass that and just inject SDL scancodes directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is specifically for the Emscripten build, it allows the containing website to access the SDL_SendKeyboardKey function directly, which is useful for linking webpage UI elements with the running emulator instance.